cert-signer.git

commit d67341edb39242245770991d0ff953ccebe498e1

Author: Paolo Lulli <paolo@lulli.net>

Refactoring

  | 0 
 src/main/java/net/lulli/certsigner/Client.java | 4 ++--
 src/main/java/net/lulli/certsigner/Settings.java | 6 +++---


diff --git a/script/createCertificate b/script/createCertificate
deleted file mode 100755
index da806beb402b8d3abd9f45eee050e7da0b5eb886..0000000000000000000000000000000000000000
--- a/script/createCertificate
+++ /dev/null
@@ -1,6 +0,0 @@
-#! /bin/bash -x
-
-cd $(dirname $0)
-source ~/.vault-credentials.cfg
-
-java -cp ../target/cert-signer-0.0.1.jar net.lulli.certsigner.Client "$@"




diff --git a/script/issueCertificate b/script/issueCertificate
new file mode 100755
index 0000000000000000000000000000000000000000..da806beb402b8d3abd9f45eee050e7da0b5eb886
--- /dev/null
+++ b/script/issueCertificate
@@ -0,0 +1,6 @@
+#! /bin/bash -x
+
+cd $(dirname $0)
+source ~/.vault-credentials.cfg
+
+java -cp ../target/cert-signer-0.0.1.jar net.lulli.certsigner.Client "$@"




diff --git a/src/main/java/net/lulli/certsigner/Client.java b/src/main/java/net/lulli/certsigner/Client.java
index 5b546123eff489dceafca927a855ad2a585f3fa8..eed807f44cdff1b0d6bf6ab537aca9f42c69766f 100644
--- a/src/main/java/net/lulli/certsigner/Client.java
+++ b/src/main/java/net/lulli/certsigner/Client.java
@@ -70,7 +70,7 @@             throw new IllegalStateException(e);
         }
     }
 
-    public String requestCertificate(String serviceName, String clientName) {
+    public String requestCertificate() {
         try {
             var client = new Client(serviceName, clientName);
 
@@ -96,7 +96,7 @@         var serviceName = args[0];
         var clientName = args[1];
 
         var client = new Client(serviceName, clientName);
-        var certificate = client.requestCertificate(serviceName, clientName);
+        var certificate = client.requestCertificate();
 
         System.out.printf("Certificate data:\n%s", certificate);
     }




diff --git a/src/main/java/net/lulli/certsigner/Settings.java b/src/main/java/net/lulli/certsigner/Settings.java
index b39eed3673d44b3e579c9642fd33c444b969a350..e6bdc955aed061294f293ffaa5e67b5926ad5fd1 100644
--- a/src/main/java/net/lulli/certsigner/Settings.java
+++ b/src/main/java/net/lulli/certsigner/Settings.java
@@ -1,7 +1,7 @@
 package net.lulli.certsigner;
 
 public interface Settings {
-    static final String BC_PROVIDER = "BC";
-    static final String KEY_ALGORITHM = "RSA";
-    static final String SIGNATURE_ALGORITHM = "SHA256withRSA";
+    String BC_PROVIDER = "BC";
+    String KEY_ALGORITHM = "RSA";
+    String SIGNATURE_ALGORITHM = "SHA256withRSA";
 }